lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 02 Nov 2017 16:28:07 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     guro@...com
Cc:     netdev@...r.kernel.org, tj@...nel.org, ast@...nel.org,
        daniel@...earbox.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/4] device_cgroup: prepare code for bpf-based
 device controller

From: Roman Gushchin <guro@...com>
Date: Wed, 1 Nov 2017 11:20:34 -0400

> diff --git a/include/linux/device_cgroup.h b/include/linux/device_cgroup.h
> index 8b64221b432b..25f1dc7673db 100644
> --- a/include/linux/device_cgroup.h
> +++ b/include/linux/device_cgroup.h
> @@ -1,16 +1,69 @@
>  #include <linux/fs.h>
>  
> +#define ACC_MKNOD 1
> +#define ACC_READ  2
> +#define ACC_WRITE 4
> +#define ACC_MASK (ACC_MKNOD | ACC_READ | ACC_WRITE)
> +
> +#define DEV_BLOCK 1
> +#define DEV_CHAR  2
> +#define DEV_ALL   4  /* this represents all devices */

When these macros existed solely inside of security/device_cgroup.c,
such naming was probably fine.

But once you move them into a global header file, we have to take
global namespace issues into consideration.

I would therefore like to ask that you give some kind of appropriate
prefix to the names of these macros, in order to make them more global
namespace friendly.

Thank you.

Powered by blists - more mailing lists