lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 2 Nov 2017 09:38:29 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lukas Wunner <lukas@...ner.de>, Andi Kleen <ak@...ux.intel.com>
Subject: Re: linux-next: manual merge of the gpio tree with the tip tree

On Thu, Nov 02, 2017 at 09:06:27AM +0100, Peter Zijlstra wrote:
> On Thu, Nov 02, 2017 at 03:59:52PM +1100, Stephen Rothwell wrote:
> > diff --cc include/linux/bitops.h
> > index 15a5bcfcd0a2,9a874deee6e2..000000000000
> > --- a/include/linux/bitops.h
> > +++ b/include/linux/bitops.h
> > @@@ -227,32 -227,30 +227,56 @@@ static inline unsigned long __ffs64(u6
> >   	return __ffs((unsigned long)word);
> >   }
> >   
> >  +/*
> >  + * clear_bit32 - Clear a bit in memory for u32 array
> >  + * @nr: Bit to clear
> >  + * @addr: u32 * address of bitmap
> >  + *
> >  + * Same as clear_bit, but avoids needing casts for u32 arrays.
> >  + */
> >  +
> >  +static __always_inline void clear_bit32(long nr, volatile u32 *addr)
> >  +{
> >  +	clear_bit(nr, (volatile unsigned long *)addr);
> >  +}
> >  +
> >  +/*
> >  + * set_bit32 - Set a bit in memory for u32 array
> >  + * @nr: Bit to clear
> >  + * @addr: u32 * address of bitmap
> >  + *
> >  + * Same as set_bit, but avoids needing casts for u32 arrays.
> >  + */
> >  +
> >  +static __always_inline void set_bit32(long nr, volatile u32 *addr)
> >  +{
> >  +	set_bit(nr, (volatile unsigned long *)addr);
> >  +}
> 
> How is that not fundamentally broken for big-endian?

I think its broken in another way as well, {set,clear}_bit() are atomic
ops that expect a naturally aligned 'unsigned long', and that cast can
break the alignment as well.

And I'm fairly sure we have architectures where the atomic ops
misbehave or maybe even trap when you don't feed them properly aligned
data.

Powered by blists - more mailing lists