linux-kernel - Re: [PATCH] arm64: write_sysreg asm illegal for aarch32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f69cfc20-60e1-6c5c-5baf-7c7ae5b58ab1@arm.com>
Date:   Thu, 2 Nov 2017 10:05:35 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Mark Salyzyn <salyzyn@...roid.com>, linux-kernel@...r.kernel.org
Cc:     Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Christoffer Dall <cdall@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Stefan Traby <stefan@...lo-penguin.com>,
        Dave Martin <Dave.Martin@....com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm64: write_sysreg asm illegal for aarch32

On 01/11/17 16:58, Mark Salyzyn wrote:
> Cross compiling to aarch32 (for vdso32) using clang correctly
> identifies that (the unused) write_sysreg inline asm directive is
> illegal in that architectural context:
> 
> arch/arm64/include/asm/arch_timer.h: error: invalid input constraint 'rZ' in asm
>         write_sysreg(cntkctl, cntkctl_el1);
>         ^
> arch/arm64/include/asm/sysreg.h: note: expanded from macro 'write_sysreg'
>                      : : "rZ" (__val));
>                          ^
> 
> GCC normally checks for correctness everywhere. But uniquely for
> unused asm, will optimize out and suppress the error report.

-ENOTABUG.

Please fix the build system instead (why on Earth are you using arm64
headers for an Aarch32 binary?), and don't introduce stuff that is
making understanding the kernel more difficult to understand and maintain.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...