lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu,  2 Nov 2017 11:38:40 +0000
From:   Chris Redpath <>
Cc:     Morten Rasmussen <>,
        Dietmar Eggemann <>,
        Chris Redpath <>,
        "Rafael J . Wysocki" <>,
        Viresh Kumar <>,
        Ingo Molnar <>,
        Peter Zijlstra <>
Subject: [PATCH v2] cpufreq: schedutil: Examine the correct CPU when we update util

4296f23ed cpufreq: schedutil: Fix per-CPU structure initialization in
We lost the value of sg_cpu->cpu which is assigned during
sugov_register. The memset in sugov_start overwrites it with zero.

The change here was triggered by the commit adding the remote update
674e75411fc2 ("sched: cpufreq: Allow remote cpufreq callbacks")

This leads to always looking at the utilization of CPU0 instead of
the one we just updated when we do a utilization update callback.

Let's fix this by consolidating the initialization code into

Fixes: 674e75411fc2 ("sched: cpufreq: Allow remote cpufreq callbacks")
Signed-off-by: Chris Redpath <>
Reviewed-by: Patrick Bellasi <>
Reviewed-by: Brendan Jackman <>
Cc: Rafael J. Wysocki <>
Cc: Viresh Kumar <>
Cc: Ingo Molnar <>
Cc: Peter Zijlstra <>
 kernel/sched/cpufreq_schedutil.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index 6c1a7fcfa2a7..dc68a1ccdb33 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -728,6 +728,7 @@ static int sugov_start(struct cpufreq_policy *policy)
 		struct sugov_cpu *sg_cpu = &per_cpu(sugov_cpu, cpu);
 		memset(sg_cpu, 0, sizeof(*sg_cpu));
+		sg_cpu->cpu = cpu;
 		sg_cpu->sg_policy = sg_policy;
 		sg_cpu->flags = SCHED_CPUFREQ_RT;
 		sg_cpu->iowait_boost_max = policy->cpuinfo.max_freq;
@@ -793,11 +794,6 @@ struct cpufreq_governor *cpufreq_default_governor(void)
 static int __init sugov_register(void)
-	int cpu;
-	for_each_possible_cpu(cpu)
-		per_cpu(sugov_cpu, cpu).cpu = cpu;
 	return cpufreq_register_governor(&schedutil_gov);

Powered by blists - more mailing lists