linux-kernel - Re: [PATCH 6/7] netdev: octeon-ethernet: Add Cavium Octeon III support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171102124339.GF4772@lunn.ch>
Date:   Thu, 2 Nov 2017 13:43:39 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     David Daney <david.daney@...ium.com>
Cc:     linux-mips@...ux-mips.org, ralf@...ux-mips.org,
        James Hogan <james.hogan@...s.com>, netdev@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-kernel@...r.kernel.org,
        "Steven J. Hill" <steven.hill@...ium.com>,
        devicetree@...r.kernel.org, Carlos Munoz <cmunoz@...ium.com>
Subject: Re: [PATCH 6/7] netdev: octeon-ethernet: Add Cavium Octeon III
 support.

> +static int bgx_probe(struct platform_device *pdev)
> +{
> +	struct mac_platform_data platform_data;
> +	const __be32 *reg;
> +	u32 port;
> +	u64 addr;
> +	struct device_node *child;
> +	struct platform_device *new_dev;
> +	struct platform_device *pki_dev;
> +	int numa_node, interface;
> +	int i;
> +	int r = 0;
> +	char id[64];
> +	u64 data;
> +
> +	reg = of_get_property(pdev->dev.of_node, "reg", NULL);
> +	addr = of_translate_address(pdev->dev.of_node, reg);
> +	interface = (addr >> 24) & 0xf;
> +	numa_node = (addr >> 36) & 0x7;
> +
> +	/* Assign 8 CAM entries per LMAC */
> +	for (i = 0; i < 32; i++) {
> +		data = i >> 3;
> +		oct_csr_write(data, BGX_CMR_RX_ADRX_CAM(numa_node, interface, i));
> +	}
> +
> +	for_each_available_child_of_node(pdev->dev.of_node, child) {
> +		snprintf(id, sizeof(id), "%llx.%u.ethernet-mac",
> +			 (unsigned long long)addr, port);
> +		new_dev = of_platform_device_create(child, id, &pdev->dev);
> +		if (!new_dev) {
> +			dev_err(&pdev->dev, "Error creating %s\n", id);
> +			continue;
> +		}
> +		platform_data.mac_type = BGX_MAC;
> +		platform_data.numa_node = numa_node;
> +		platform_data.interface = interface;
> +		platform_data.port = port;
> +		if (is_xcv)
> +			platform_data.src_type = XCV;
> +		else
> +			platform_data.src_type = QLM;
> +
> +		/* Add device to the list of created devices so we can remove it
> +		 * on exit.
> +		 */
> +		pdev_item = kmalloc(sizeof(*pdev_item), GFP_KERNEL);
> +		pdev_item->pdev = new_dev;
> +		mutex_lock(&pdev_list_lock);
> +		list_add(&pdev_item->list, &pdev_list);
> +		mutex_unlock(&pdev_list_lock);
> +
> +		i = atomic_inc_return(&pki_id);
> +		pki_dev = platform_device_register_data(&new_dev->dev,
> +							is_mix ? "octeon_mgmt" : "ethernet-mac-pki",
> +							i, &platform_data, sizeof(platform_data));
> +		dev_info(&pdev->dev, "Created %s %u: %p\n",
> +			 is_mix ? "MIX" : "PKI", pki_dev->id, pki_dev);

Is there any change of these ethernet ports being used to connect to
an Ethernet switch. We have had issues in the past with these sort of
platform devices combined with DSA.

	 Andrew