linux-kernel - Re: [PATCH v7 2/2] bus: add driver for the Technologic Systems NBUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7a79314-66ff-6f09-6e53-aa548286b962@savoirfairelinux.com>
Date:   Thu, 2 Nov 2017 10:37:45 -0400
From:   Sebastien Bourdelin <sebastien.bourdelin@...oirfairelinux.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kernel <kernel@...oirfairelinux.com>,
        Rob Herring <robh@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Fabio Estevam <fabio.estevam@....com>,
        Mark Featherston <mark@...eddedarm.com>, kris@...eddedarm.com
Subject: Re: [PATCH v7 2/2] bus: add driver for the Technologic Systems NBUS

Hi Linus,

On 11/02/2017 10:22 AM, Linus Walleij wrote:
> On Wed, Nov 1, 2017 at 6:14 PM, Sebastien Bourdelin
> <sebastien.bourdelin@...oirfairelinux.com> wrote:
> 
>> This driver implements a GPIOs bit-banged bus, called the NBUS by
>> Technologic Systems. It is used to communicate with the peripherals in
>> the FPGA on the TS-4600 SoM.
>>
>> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@...oirfairelinux.com>
>> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> 
> This is still a very nice driver.

Thanks that's very kind and greatly appreciate.
> 
> If you are working on supplemental patches: from the next merge window
> we will have:
> 
> + int gpiod_get_array_value_cansleep(unsigned int array_size,
> +                                          struct gpio_desc **desc_array,
> +                                          int *value_array);
> 
> See:
> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/commit/?h=devel&id=eec1d566cdf94b57e8f5ba9fe60eea214929bcfc
> 
> If your GPIO controller also has .get_multiple() implemented it just
> becomes one register read if you're lucky.
> 
Ok, i guess i will not if this is fine like that, i'll see if someone
suggested some changes.

> BTW do you have a way upstream for this patch? ARM SoC?
Honestly i have no idea, do you have a recommandation for this kind of
bus driver? should i re-submit just this patch to a specific tree?

> 
> Yours,
> Linus Walleij
> 

Thanks again for your inputs.

Best regards,
Sebastien Bourdelin.