lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 2 Nov 2017 09:44:03 -0500
From:   Dave Kleikamp <dave.kleikamp@...cle.com>
To:     Juerg Haefliger <juerg.haefliger@...onical.com>,
        jfs-discussion@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [Jfs-discussion] [PATCH] jfs: Add missing NULL pointer check in
 __get_metapage

On 11/02/2017 08:43 AM, Juerg Haefliger wrote:

>>>> Furthermore, it looks like all the callers of __get_metapage() check for
>>>> a null return, so I'm not sure we need to handle the error at this
>>>> point. I might have to look a bit harder at that, since there are many
>>>> callers.
>>>
>>> I don't understand this either :-) Yes, the callers do check for a null
>>> pointer but things blow up (in __get_metapage) before that check without
>>> the above fix.
>>
>> Yeah, the fix to __get_metapage() is necessary. I'm not convinced the
>> first part of the patch, to alloc_metapage(), is necessary.
> 
> It's not. I just thought it'd be nice to get some sort of notification
> in the log when the alloc fails. But if the callers log it then that's fine.

Okay. I'll push just the __get_metapage part of your patch.

Thanks,
Shaggy

Powered by blists - more mailing lists