linux-kernel - Re: [PATCH] block: fix CDROM dependency on BLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1509634781.2484.3.camel@wdc.com>
Date:   Thu, 2 Nov 2017 14:59:42 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "arnd@...db.de" <arnd@...db.de>,
        "axboe@...nel.dk" <axboe@...nel.dk>
CC:     "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "hare@...e.com" <hare@...e.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH] block: fix CDROM dependency on BLK_DEV

On Thu, 2017-11-02 at 12:19 +0100, Arnd Bergmann wrote:
> After the cdrom cleanup, I get randconfig warnings for some configurations:
> 
> warning: (BLK_DEV_IDECD && BLK_DEV_SR) selects CDROM which has unmet direct dependencies (BLK_DEV)

Hello Arnd,

Since Jens has already queued your patch it's too late to consider alternatives.
Anyway, since the cdrom driver calls block layer functions directly, have you
considered the following alternative?

diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index 0dad1d2536f7..e7044c893817 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -69,6 +69,7 @@ config AMIGA_Z2RAM
 
 config CDROM
 	tristate "CD-ROM driver"
+	depends on BLK_DEV
 	help
 	  A CD-ROM is a pre-pressed optical compact disc which contains
 	  data. The name is an acronym which stands for "Compact Disc