lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 2 Nov 2017 16:40:57 +0100
From:   Arnd Bergmann <>
To:     Kalle Valo <>
Cc:     Ryan Hsu <>,
        Govind Singh <>,
        Srinivas Kandagatla <>,
        Ashok Raj Nagarajan <>,
        Ben Greear <>,
        Brian Norris <>,
        Colin Ian King <>,
        "" <>,
        "" <>,
        "" <>,
        "" <>
Subject: Re: [PATCH] ath10k: move pci suspend/resume functions

On Thu, Nov 2, 2017 at 4:23 PM, Kalle Valo <> wrote:
> Arnd Bergmann <> writes:
>> The combination of two patches has led to a build failure:
>> drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_suspend':
>> drivers/net/wireless/ath/ath10k/pci.c:3416:8: error: implicit declaration of function 'ath10k_pci_suspend'; did you mean 'ath10k_pci_pm_suspend'? [-Werror=implicit-function-declaration]
>> drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_resume':
>> drivers/net/wireless/ath/ath10k/pci.c:3428:8: error: implicit declaration of function 'ath10k_pci_resume'; did you mean 'ath10k_pci_pm_resume'? [-Werror=implicit-function-declaration]
>> This moves the functions outside of the now incorrect #ifdef.
>> Fixes: 96378bd2c6cd ("ath10k: fix core PCI suspend when WoWLAN is supported but disabled")
>> Fixes: 6af1de2e4ec4 ("ath10k: mark PM functions as __maybe_unused")
>> Signed-off-by: Arnd Bergmann <>
> Brian has already fixed this, please check that:
> But apparently I forgot to merge ath-next to wireless-drivers-next, will
> do that soon.

Yes, Brian's version is better. I considered the same, but wasn't sure
it was safe.


Powered by blists - more mailing lists