linux-kernel - Re: usb/misc/ims-pcu: slab-out-of-bounds in ims_pcu_parse_cdc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Nov 2017 09:25:35 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Andrey Konovalov <andreyknvl@...gle.com>
Cc:     Johan Hovold <johan@...nel.org>,
        Arvind Yadav <arvind.yadav.cs@...il.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Kostya Serebryany <kcc@...gle.com>,
        syzkaller <syzkaller@...glegroups.com>
Subject: Re: usb/misc/ims-pcu: slab-out-of-bounds in ims_pcu_parse_cdc_data

Hi Andrey,

On Thu, Nov 2, 2017 at 9:13 AM, Andrey Konovalov <andreyknvl@...gle.com> wrote:
> On Sat, Oct 7, 2017 at 8:14 PM, Dmitry Torokhov
> <dmitry.torokhov@...il.com> wrote:
>> On Thu, Sep 28, 2017 at 01:35:51PM +0200, Andrey Konovalov wrote:
>>> Hi!
>>>
>>> I've got the following report while fuzzing the kernel with syzkaller.
>>>
>>> On commit dc972a67cc54585bd83ad811c4e9b6ab3dcd427e (4.14-rc2+).
>>>
>>> There's no check that the length of intf->altsetting->extra is big
>>> enough to hold usb_cdc_union_desc struct.
>>
>> Can you please tell me if the following works for you?
>
> Hi Dmitry,
>
> Could you mail this patch upstream?

It is already there:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/input/misc/ims-pcu.c?id=ea04efee7635c9120d015dcdeeeb6988130cb67a

Thanks.

-- 
Dmitry