lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 2 Nov 2017 18:23:25 +0100 From: Paolo Bonzini <pbonzini@...hat.com> To: Jason Gunthorpe <jgg@...pe.ca>, kvm@...r.kernel.org, linux-kernel@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, Radim Krm <rkrcmar@...hat.com> Subject: Re: [PATCH] kvm: Return -ENODEV from update_persistent_clock On 31/10/2017 21:28, Jason Gunthorpe wrote: > kvm does not support setting the RTC, so the correct result is -ENODEV. > Returning -1 will cause sync_cmos_clock to keep trying to set the RTC > every second. > > Signed-off-by: Jason Gunthorpe <jgg@...pe.ca> > --- > arch/x86/kernel/kvmclock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c > index d88967659098b5..5b609e28ce3f40 100644 > --- a/arch/x86/kernel/kvmclock.c > +++ b/arch/x86/kernel/kvmclock.c > @@ -79,7 +79,7 @@ static void kvm_get_wallclock(struct timespec *now) > > static int kvm_set_wallclock(const struct timespec *now) > { > - return -1; > + return -ENODEV; > } > > static u64 kvm_clock_read(void) > Queued, thanks. Paolo
Powered by blists - more mailing lists