linux-kernel - Re: [Part2 PATCH v7 13/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f54e39f-7e2b-26d0-2d22-b8ccbef67c3d@amd.com>
Date:   Thu, 2 Nov 2017 12:32:39 -0500
From:   Brijesh Singh <brijesh.singh@....com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     brijesh.singh@....com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Gary Hook <gary.hook@....com>,
        Tom Lendacky <thomas.lendacky@....com>,
        linux-crypto@...r.kernel.org
Subject: Re: [Part2 PATCH v7 13/38] crypto: ccp: Add Secure Encrypted
 Virtualization (SEV) command support



On 11/02/2017 12:10 PM, Borislav Petkov wrote:
...

>>   drivers/crypto/ccp/psp-dev.c | 350 +++++++++++++++++++++++++++++++++++++++++++
>>   drivers/crypto/ccp/psp-dev.h |  24 +++
>>   drivers/crypto/ccp/sp-dev.c  |   9 ++
>>   drivers/crypto/ccp/sp-dev.h  |   4 +
>>   include/linux/psp-sev.h      | 143 ++++++++++++++++++
>>   5 files changed, 530 insertions(+)
> 
> Some more cleanups:
> 
> * If sev_data_init is per psp_device, you can simply embed it in the
> struct psp_device and save yourself the complete allocation.
> 
> * s/sev_ops_init/sev_misc_init/ because it doesn't do anything ops-like
> 
> * save some header lines.
> 


Thanks for the cleanup patch, I will apply these changes. Additionally, 
I will also embed the sev_user_data_platform_status in per psp_device 
struct instead of dvmem_kzalloc().


-Brijesh