linux-kernel - Re: [GIT PULL] License cleanup: add SPDX license identifiers to some kernel files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171102174542.GB27444@kroah.com>
Date:   Thu, 2 Nov 2017 18:45:42 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] License cleanup: add SPDX license identifiers to some
 kernel files

On Thu, Nov 02, 2017 at 10:32:17AM -0700, Linus Torvalds wrote:
> On Thu, Nov 2, 2017 at 10:25 AM, Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
> >
> > So to me, the "just put it as the first syntactically possible line,
> > and just always use the same comment format" is simply to avoid
> > unnecessary arguments/conflicts about which of any number of ways you
> > *could* do it.
> 
> Side note: I'm not going to enforce it, it's just a personal wish to
> hopefully make my life easier.
> 
> This pull request from Greg already has different comment formats for
> different files. I pulled it despite that.

It should have been consistent, everything except the script files went
as the first line of the file.

For .h files, we had to use /* */
For .c files, we used //
For scripts, and asm, we used the comment "marker" that was used in the
file already.

Attached is the script written by Thomas and tweaked by me to do all of
the tag insertion based on a csv file, it picks the format based on the
name and content of the file.

thanks,

greg k-h

View attachment "spdxtags2.py" of type "text/x-python" (3312 bytes)