linux-kernel - Re: [PATCH 1/1] Fix: vmw_vmci driver get_user_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171102184612.GL21978@ZenIV.linux.org.uk>
Date:   Thu, 2 Nov 2017 18:46:12 +0000
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc:     linux-kernel@...r.kernel.org,
        George Zhang <georgezhang@...are.com>,
        Andy king <acking@...are.com>,
        Dmitry Torokhov <dtor@...are.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 1/1] Fix: vmw_vmci driver get_user_pages_fast error
 handling

On Tue, Oct 31, 2017 at 07:00:38PM -0400, Mathieu Desnoyers wrote:
> Comparing a signed return value against an unsigned num_pages
> field performs the comparison as "unsigned", and therefore mistakenly
> considers get_user_pages_fast() errors as success.

It's worse than that - if you look into the code in question you'll
see
                pr_debug("get_user_pages_fast(produce) failed (retval=%d)",
                        retval);
                qp_release_pages(produce_q->kernel_if->u.h.header_page,
                                 retval, false);
                err = VMCI_ERROR_NO_MEM;
                goto out;
with
static void qp_release_pages(struct page **pages,
                             u64 num_pages, bool dirty)
{
        int i;

        for (i = 0; i < num_pages; i++) {
                if (dirty)
                        set_page_dirty(pages[i]);

                put_page(pages[i]);
                pages[i] = NULL;
        }
}

Now, guess what'll happen if you get there with retval being negative?
AFAICS, the right fix is something along the lines of
        if (retval != produce_q->kernel_if->num_pages) {
                pr_debug("get_user_pages_fast(produce) failed (retval=%d)",
                        retval);
		if (retval > 0)
			qp_release_pages(produce_q->kernel_if->u.h.header_page,
					 retval, false);
                err = VMCI_ERROR_NO_MEM;
                goto out;
        }
and similar for the second caller.  Objections?