linux-kernel - Re: [PATCH] xen/pvcalls: fix unsigned less than zero error check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2116793f-cd52-a99f-772e-5dcb768ad411@suse.com>
Date:   Fri, 3 Nov 2017 10:01:16 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Colin King <colin.king@...onical.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        xen-devel@...ts.xenproject.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xen/pvcalls: fix unsigned less than zero error check

On 03/11/17 09:42, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The check on bedata->ref is never true because ref is an unsigned
> integer. Fix this by assigning signed int ret to the return of the
> call to gnttab_claim_grant_reference so the -ve return can be checked.
> 
> Detected by CoverityScan, CID#1460358 ("Unsigned compared against 0")
> 
> Fixes: 219681909913 ("xen/pvcalls: connect to the backend")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Juergen Gross <jgross@...e.com>


Juergen