linux-kernel - Re: [PATCH] xen/pvcalls: remove redundant check for irq >= 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9627c5a-c1b4-71b2-fba4-5cefa24c33ba@suse.com>
Date:   Fri, 3 Nov 2017 11:01:29 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Colin King <colin.king@...onical.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        xen-devel@...ts.xenproject.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xen/pvcalls: remove redundant check for irq >= 0

On 03/11/17 10:20, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> This is a moot point, but irq is always less than zero at the label
> out_error, so the check for irq >= 0 is redundant and can be removed.
> 
> Detected by CoverityScan, CID#1460371 ("Logically dead code")
> 
> Fixes: cb1c7d9bbc87 ("xen/pvcalls: implement connect command")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Juergen Gross <jgross@...e.com>


Juergen