linux-kernel - Re: [PATCH v2 2/3] Sony-laptop: Delete an unnecessary variable initialisation in sony_nc_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeqvKHLiSSdQGYLjBdqdPcFt7gaeKpXpWCtFv93ZaR1sg@mail.gmail.com>
Date:   Fri, 3 Nov 2017 14:00:32 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        Darren Hart <dvhart@...radead.org>,
        Marco Chiappero <marco@...ence.it>,
        Mattia Dongili <malattia@...ux.it>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Andy Shevchenko <andy@...radead.org>
Subject: Re: [PATCH v2 2/3] Sony-laptop: Delete an unnecessary variable
 initialisation in sony_nc_setup_rfkill()

On Wed, Nov 1, 2017 at 8:47 PM, SF Markus Elfring
<elfring@...rs.sourceforge.net> wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Wed, 1 Nov 2017 19:00:59 +0100
>
> The local variable "err" will eventually be set to an appropriate value
> a bit later. Thus omit the explicit initialisation at the beginning.

Applied to my review and testing queue, thanks!

>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/platform/x86/sony-laptop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
> index 4332cc982ce0..62aa2c37b8d2 100644
> --- a/drivers/platform/x86/sony-laptop.c
> +++ b/drivers/platform/x86/sony-laptop.c
> @@ -1627,7 +1627,7 @@ static const struct rfkill_ops sony_rfkill_ops = {
>  static int sony_nc_setup_rfkill(struct acpi_device *device,
>                                 enum sony_nc_rfkill nc_type)
>  {
> -       int err = 0;
> +       int err;
>         struct rfkill *rfk;
>         enum rfkill_type type;
>         const char *name;
> --
> 2.14.3
>



-- 
With Best Regards,
Andy Shevchenko