lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 3 Nov 2017 14:40:51 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Guillaume Douézan-Grard 
        <gdouezangrard@...il.com>
Cc:     Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/4] platform/x86: topstar-laptop: non-functional changes

On Sun, Oct 29, 2017 at 1:50 AM, Guillaume Douézan-Grard
<gdouezangrard@...il.com> wrote:
> Minor consistency changes to prepare further addition of platform device
> and LED.
>
> More precisely:
>
> * more consistent naming (module description, header text, devices names
> and programming constructs),
>
> * clear separation between systems (ACPI events and input handling),
>
> * copyright and module authors update.

So, since I would anticipated a new version of the patch series, I
would suggest to split this one to few patches:

1. Only renaming
2. Only moving functions around (separation part?)
3. Only indentation / style fixes + your author ship (should be last
in the entire series)


-- 
With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists