linux-kernel - Re: [PATCH v2 3/4] platform/x86: topstar-laptop: add platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcsZsWxYgwQL9yja45vwo0_kShdCEoa_WreFU7fYLYW_A@mail.gmail.com>
Date:   Fri, 3 Nov 2017 14:47:36 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Guillaume Douézan-Grard 
        <gdouezangrard@...il.com>
Cc:     Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/4] platform/x86: topstar-laptop: add platform device

On Sun, Oct 29, 2017 at 1:52 AM, Guillaume Douézan-Grard
<gdouezangrard@...il.com> wrote:
> * add platform device to support further addition of a led subsystem,
>
> * add existing input device to the new platform device.

>  #include <linux/init.h>
>  #include <linux/slab.h>
>  #include <linux/acpi.h>
> +#include <linux/platform_device.h>
>  #include <linux/input.h>
>  #include <linux/input/sparse-keymap.h>

Please, keep it ordered as much as possible, i.e. add the line after
sparse-keymap.

-- 
With Best Regards,
Andy Shevchenko