lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 3 Nov 2017 21:00:11 +0800
From:   "Jin, Yao" <>
To:     Jiri Olsa <>,
Subject: Re: [PATCH v5 2/6] perf record: Get the first sample time and last
 sample time

On 10/24/2017 3:16 PM, Jiri Olsa wrote:
> On Tue, Oct 24, 2017 at 10:03:05AM +0800, Jin, Yao wrote:
>>> hum, could you still unset the sample if there's no time given?
>>> and keep the speed in this case..
>>> jirka
>> Hi Jiri,
>> I check this question again. The '--time' option is for perf report but not
>> for perf record.
>> For perf record, we have to always walk on all samples to get the time of
>> first sample and the time of last sample whatever buildid_all is enabled or
>> not enabled. So 'rec->tool.sample = NULL' is removed.
>> Sorry, the previous mail was replied at midnight, I was drowsy. :(
>> If my answer is correct, I will not send v6. If my understanding is still
>> not correct, please let me know.
> right, I did not realize we store this unconditionaly.. then yes, it's ok
> I think I've already acked this, anyway for the patchset:
> Acked-by: Jiri Olsa <>
> thanks,
> jirka

Hi Arnaldo,

Is this patch-set OK for merging or anything I should improve?

Jin Yao

Powered by blists - more mailing lists