linux-kernel - Re: [PATCH] soc: qcom: remove unused label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01a0ee1e-660c-80b2-150a-78f13b12fd46@ieee.org>
Date:   Fri, 3 Nov 2017 08:17:50 -0500
From:   Alex Elder <elder@...e.org>
To:     Arnd Bergmann <arnd@...db.de>, Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>
Cc:     Rob Herring <robh@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: remove unused label

On 10/18/2017 03:30 AM, Arnd Bergmann wrote:
> The newly added driver comes with a harmless warning:
> 
> drivers/soc/qcom/rmtfs_mem.c: In function 'qcom_rmtfs_mem_probe':
> drivers/soc/qcom/rmtfs_mem.c:211:1: error: label 'remove_cdev' defined but not used [-Werror=unused-label]
> 
> This removes the unused label to avoid the warning.
> 
> Fixes: 702baebb8e00 ("soc: qcom: Remote filesystem memory driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Looks good.

Reviewed-by: Alex Elder <elder@...aro.org>

> ---
>  drivers/soc/qcom/rmtfs_mem.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c
> index f6f2f0cb3b3a..ce35ff748adf 100644
> --- a/drivers/soc/qcom/rmtfs_mem.c
> +++ b/drivers/soc/qcom/rmtfs_mem.c
> @@ -208,8 +208,6 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev)
>  
>  	return 0;
>  
> -remove_cdev:
> -	cdev_device_del(&rmtfs_mem->cdev, &rmtfs_mem->dev);
>  put_device:
>  	put_device(&rmtfs_mem->dev);
>  
>