linux-kernel - [PATCH] platform/x86: hp-wmi: Fix tablet mode detection for convertibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Nov 2017 03:01:53 +0100
From:   Stefan Brüns <stefan.bruens@...h-aachen.de>
To:     <platform-driver-x86@...r.kernel.org>
CC:     Stefan Brüns <stefan.bruens@...h-aachen.de>,
        "Andy Shevchenko" <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        <linux-kernel@...r.kernel.org>
Subject: [PATCH] platform/x86: hp-wmi: Fix tablet mode detection for convertibles

Commit f9cf3b2880cc ("platform/x86: hp-wmi: Refactor dock and tablet
state fetchers") consolidated the methods for docking and laptop mode
detection, but omitted to apply the correct mask for the laptop mode
(it always uses the constant for docking).

Signed-off-by: Stefan Brüns <stefan.bruens@...h-aachen.de>

---

This change is untested, but restores the previous behaviour.
---
 drivers/platform/x86/hp-wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
index b4ed3dc983d5..b4224389febe 100644
--- a/drivers/platform/x86/hp-wmi.c
+++ b/drivers/platform/x86/hp-wmi.c
@@ -297,7 +297,7 @@ static int hp_wmi_hw_state(int mask)
 	if (state < 0)
 		return state;
 
-	return state & 0x1;
+	return !!(state & mask);
 }
 
 static int __init hp_wmi_bios_2008_later(void)
-- 
2.14.3