linux-kernel - Re: [PATCH] selftests: lib.mk: print individual test results to console by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fu9w6qd8.fsf@concordia.ellerman.id.au>
Date:   Fri, 03 Nov 2017 13:35:47 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Shuah Khan <shuahkh@....samsung.com>, shuah@...nel.org
Cc:     Shuah Khan <shuahkh@....samsung.com>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests: lib.mk: print individual test results to console by default

Shuah Khan <shuahkh@....samsung.com> writes:

> Change run_tests to print individual test results to console by default.
> Introduce "summary" option to print individual test results to a file
> /tmp/test_name and just print the summary to the console.
>
> This change is necessary to support use-cases where test machines get
> rebooted once tests are run and the console log should contain the full
> results.
>
> In the following example, individual test results with "summary=1" option
> are written to /tmp/kcmp_test
>
> make --silent TARGETS=kcmp kselftest
>
> TAP version 13
> selftests: kcmp_test
> ========================================
> pid1:  30126 pid2:  30127 FD:  2 FILES:  2 VM:  1 FS:  2 SIGHAND:  2 IO:
> 0 SYSVSEM:  0 INV: -1
> PASS: 0 returned as expected
> PASS: 0 returned as expected
> FAIL: 0 expected but -1 returned (Invalid argument)
> Pass 2 Fail 1 Xfail 0 Xpass 0 Skip 0 Error 0
> 1..3
> Bail out!
> Pass 2 Fail 1 Xfail 0 Xpass 0 Skip 0 Error 0
> 1..3
> Pass 0 Fail 0 Xfail 0 Xpass 0 Skip 0 Error 0
> 1..0
> ok 1..1 selftests: kcmp_test [PASS]
>
> make --silent TARGETS=kcmp summary=1 kselftest
> TAP version 13
> selftests: kcmp_test
> ========================================
> ok 1..1 selftests: kcmp_test [PASS]
>
> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> ---
>  tools/testing/selftests/lib.mk | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

This looks good to me as a minimal fix, thanks.

Acked-by: Michael Ellerman <mpe@...erman.id.au>

cheers