linux-kernel - RE: [PATCH v7 2/5] irqchip/irq-goldfish-pic: Add Goldfish PIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 Nov 2017 14:10:13 +0000
From:   Aleksandar Markovic <Aleksandar.Markovic@...s.com>
To:     Joe Perches <joe@...ches.com>,
        Aleksandar Markovic <aleksandar.markovic@...rk.com>,
        "linux-mips@...ux-mips.org" <linux-mips@...ux-mips.org>
CC:     Miodrag Dinic <Miodrag.Dinic@...s.com>,
        Goran Ferenc <Goran.Ferenc@...s.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Douglas Leung" <Douglas.Leung@...s.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        James Hogan <James.Hogan@...s.com>,
        "Jason Cooper" <jason@...edaemon.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Marc Zyngier <marc.zyngier@....com>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        Miodrag Dinic <miodrag.dinic@...tec.com>,
        Paul Burton <Paul.Burton@...s.com>,
        "Petar Jovanovic" <Petar.Jovanovic@...s.com>,
        Raghu Gandham <Raghu.Gandham@...s.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        "Thomas Gleixner" <tglx@...utronix.de>
Subject: RE: [PATCH v7 2/5] irqchip/irq-goldfish-pic: Add Goldfish PIC driver

> From: Joe Perches [joe@...ches.com]
> ...
>On Thu, 2017-11-02 at 17:21 +0100, Aleksandar Markovic wrote:
> ...
>
> > Signed-off-by: Miodrag Dinic <miodrag.dinic@...s.com>
> > Signed-off-by: Goran Ferenc <goran.ferenc@...s.com>
> > Signed-off-by: Aleksandar Markovic <aleksandar.markovic@...s.com>
> > wq
> 
> vi much?
> 

:)

> > +/*
> > + * Driver for MIPS Goldfish Programmable Interrupt Controller.
> > + *
> > + * Author: Miodrag Dinic <miodrag.dinic@...s.com>
> > + *
> > + * This program is free software; you can redistribute       it and/or modify it
> > + * under  the terms of       the GNU General  Public License as published by the
> > + * Free Software Foundation;  either version 2 of the  License, or (at your
> > + * option) any later version.
> > + */
> 
> Odd mix of spaces and tabs
> 

Will be fixed in v8.

> It'd be good to add a #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> before any #include so the pr_<level> output is prefixed appropriately.

Error and info messages will be completely revised in v8.

Thanks for the review!

Aleksandar