linux-kernel - Re: [PATCH v2 2/5] perf/x86: add PERF_SAMPLE_SKID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171103150505.GB32113@krava>
Date:   Fri, 3 Nov 2017 16:05:05 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Stephane Eranian <eranian@...gle.com>
Cc:     linux-kernel@...r.kernel.org, acme@...hat.com,
        peterz@...radead.org, mingo@...e.hu, ak@...ux.intel.com,
        kan.liang@...el.com, Stephane Eranian <eranian@...il.com>
Subject: Re: [PATCH v2 2/5] perf/x86: add PERF_SAMPLE_SKID_IP support for X86
 PEBS

On Thu, Nov 02, 2017 at 11:15:56AM -0700, Stephane Eranian wrote:
> From: Stephane Eranian <eranian@...il.com>
> 
> This atch adds support for SKID_IP to Intel x86 processors in PEBS
> mode.

s/atch/patch/

> 
> Signed-off-by: Stephane Eranian <eranian@...gle.com>
> ---
>  arch/x86/events/intel/ds.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/x86/events/intel/ds.c b/arch/x86/events/intel/ds.c
> index e1965e5ff570..b7afdf88f441 100644
> --- a/arch/x86/events/intel/ds.c
> +++ b/arch/x86/events/intel/ds.c
> @@ -1189,6 +1189,13 @@ static void setup_pebs_sample_data(struct perf_event *event,
>  	    x86_pmu.intel_cap.pebs_format >= 1)
>  		data->addr = pebs->dla;
>  
> +	/*
> +	 * unmodified, skid IP which is guaranteed to be the next
> +	 * dyanmic instruction
> +	 */

s/dyanmic/dynamic/

jirka

> +	if (sample_type & PERF_SAMPLE_SKID_IP)
> +		data->skid_ip = pebs->ip;
> +
>  	if (x86_pmu.intel_cap.pebs_format >= 2) {
>  		/* Only set the TSX weight when no memory weight. */
>  		if ((sample_type & PERF_SAMPLE_WEIGHT) && !fll)
> -- 
> 2.7.4
>