lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 03 Nov 2017 23:08:23 +0800
From:   宋云龙 <yunlong.song@...oud.com>
To:     Jaegeuk Kim <jaegeuk@...nel.org>
Cc:     Yunlong Song <yunlong.song@...wei.com>, chao@...nel.org,
        yuchao0@...wei.com, miaoxie@...wei.com, bintian.wang@...wei.com,
        linux-fsdevel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] f2fs: add bug_on when f2fs_gc even fails to get one
 victim

OK to me.

> 
> 
>> On 10/13, Yunlong Song wrote:
>> This can help us to debug on some corner case.
>> 
>> Signed-off-by: Yunlong Song <yunlong.song@...wei.com>
>> Signed-off-by: Chao Yu <yuchao0@...wei.com>
>> ---
>> fs/f2fs/gc.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>> 
>> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
>> index 197ebf4..2b03202 100644
>> --- a/fs/f2fs/gc.c
>> +++ b/fs/f2fs/gc.c
>> @@ -986,6 +986,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync,
>>        .ilist = LIST_HEAD_INIT(gc_list.ilist),
>>        .iroot = RADIX_TREE_INIT(GFP_NOFS),
>>    };
>> +    bool need_fggc = false;
>> 
>>    trace_f2fs_gc_begin(sbi->sb, sync, background,
>>                get_pages(sbi, F2FS_DIRTY_NODES),
>> @@ -1018,8 +1019,10 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync,
>>            if (ret)
>>                goto stop;
>>        }
>> -        if (has_not_enough_free_secs(sbi, 0, 0))
>> +        if (has_not_enough_free_secs(sbi, 0, 0)) {
>>            gc_type = FG_GC;
>> +            need_fggc = true;
>> +        }
>>    }
>> 
>>    /* f2fs_balance_fs doesn't need to do BG_GC in critical path. */
>> @@ -1028,6 +1031,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync,
>>        goto stop;
>>    }
>>    if (!__get_victim(sbi, &segno, gc_type)) {
>> +        f2fs_bug_on(sbi, !total_freed && need_fggc);
> 
> Just like this?
> 
>        f2fs_bug_on(sbi, !total_freed && !sync && gc_type == FG_GC);

Agree

> 
>>        ret = -ENODATA;
>>        goto stop;
>>    }
>> -- 
>> 1.8.5.2

Powered by blists - more mailing lists