lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 03 Nov 2017 10:30:37 -0700 From: Joe Perches <joe@...ches.com> To: Aleksandar Markovic <aleksandar.markovic@...rk.com>, linux-mips@...ux-mips.org Cc: Miodrag Dinic <miodrag.dinic@...s.com>, Goran Ferenc <goran.ferenc@...s.com>, Aleksandar Markovic <aleksandar.markovic@...s.com>, "David S. Miller" <davem@...emloft.net>, Douglas Leung <douglas.leung@...s.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, James Hogan <james.hogan@...s.com>, Jason Cooper <jason@...edaemon.net>, linux-kernel@...r.kernel.org, Marc Zyngier <marc.zyngier@....com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Miodrag Dinic <miodrag.dinic@...tec.com>, Paul Burton <paul.burton@...s.com>, Petar Jovanovic <petar.jovanovic@...s.com>, Raghu Gandham <raghu.gandham@...s.com>, Randy Dunlap <rdunlap@...radead.org>, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [PATCH v8 2/5] irqchip/irq-goldfish-pic: Add Goldfish PIC driver On Fri, 2017-11-03 at 18:21 +0100, Aleksandar Markovic wrote: > From: Miodrag Dinic <miodrag.dinic@...s.com> [] > diff --git a/drivers/irqchip/irq-goldfish-pic.c b/drivers/irqchip/irq-goldfish-pic.c [] > +static int __init goldfish_pic_of_init(struct device_node *of_node, > + struct device_node *parent) > +{ [] > + parent_irq = irq_of_parse_and_map(of_node, 0); > + if (!parent_irq) { > + pr_err("Failed to map parent IRQ!"); All the pr_<foo> uses should end with a newline pr_err("Failed to map parent IRQ\n"); etc... > + gc = irq_alloc_generic_chip("GFPIC", 1, GFPIC_IRQ_BASE, gfpic->base, > + handle_level_irq); > + if (!gc) { > + pr_err("Failed to allocate chip structures!"); > + ret = -ENOMEM; > + goto out_unmap_irq; > + }
Powered by blists - more mailing lists