linux-kernel - Re: [PATCH] USB: dummy-hcd: don't set gadget.speed in dummy_hub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1711031347180.1743-100000@iolanthe.rowland.org>
Date:   Fri, 3 Nov 2017 13:47:32 -0400 (EDT)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Roger Quadros <rogerq@...com>
cc:     balbi@...nel.org, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB: dummy-hcd: don't set gadget.speed in dummy_hub_control()

On Fri, 3 Nov 2017, Roger Quadros wrote:

> There will never be a case when gadget.speed isn't already
> USB_SPEED_FULL if connection is not USB-3 and gadget.speed
> is not USB_SPEED_HIGH or USB_SPEED_LOW.
> 
> Remove the unnecessary code.
> 
> Signed-off-by: Roger Quadros <rogerq@...com>
> ---
>  drivers/usb/gadget/udc/dummy_hcd.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
> index c42ca8e..41cefc5 100644
> --- a/drivers/usb/gadget/udc/dummy_hcd.c
> +++ b/drivers/usb/gadget/udc/dummy_hcd.c
> @@ -2166,8 +2166,6 @@ static int dummy_hub_control(
>  							USB_PORT_STAT_LOW_SPEED;
>  						break;
>  					default:
> -						dum_hcd->dum->gadget.speed =
> -							USB_SPEED_FULL;
>  						break;
>  					}
>  				}

Acked-by: Alan Stern <stern@...land.harvard.edu>