linux-kernel - Re: [PATCH 1/4] Input: sparse-keymap - send sync event for KE_SW/KW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171103191756.jee5272ml2lfgcvx@dtor-ws>
Date:   Fri, 3 Nov 2017 12:17:56 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Stefan Brüns <stefan.bruens@...h-aachen.de>
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-input@...r.kernel.org
Subject: Re: [PATCH 1/4] Input: sparse-keymap - send sync event for
 KE_SW/KW_VSW

On Fri, Nov 03, 2017 at 08:03:26PM +0100, Stefan Brüns wrote:
> Sync events are sent by sparse_keymap_report_entry for normal KEY_*
> events, and are generated by several drivers after generating
> SW_* events, so sparse_keymap_report_entry should do the same.
> 
> Without the sync, events are accumulated in the kernel.
> 
> Currently, no driver uses sparse-keymap for SW_* events, but
> it is required for the intel-vbtn platform driver to generate
> SW_TABLET_MODE events.
> 
> Signed-off-by: Stefan Brüns <stefan.bruens@...h-aachen.de>

Applied, thank you.

> ---
> 
>  drivers/input/sparse-keymap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/sparse-keymap.c b/drivers/input/sparse-keymap.c
> index bb0349fa64bc..fd03e55768c9 100644
> --- a/drivers/input/sparse-keymap.c
> +++ b/drivers/input/sparse-keymap.c
> @@ -255,6 +255,7 @@ void sparse_keymap_report_entry(struct input_dev *dev, const struct key_entry *k
>  
>  	case KE_VSW:
>  		input_report_switch(dev, ke->sw.code, value);
> +		input_sync(dev);
>  		break;
>  	}
>  }
> -- 
> 2.14.3
> 

-- 
Dmitry