linux-kernel - Re: [PATCH] tracing: make PREEMPTIRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171104055802.ce04eeab4849b09bc8c0295e@kernel.org>
Date:   Sat, 4 Nov 2017 05:58:02 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: make PREEMPTIRQ_EVENTS depend on TRACING

On Fri,  3 Nov 2017 11:39:57 +0100
Arnd Bergmann <arnd@...db.de> wrote:

> When CONFIG_TRACING is disabled, the new preemptirq events tracer
> produces a build failure:
> 
> In file included from kernel/trace/trace_irqsoff.c:17:0:
> kernel/trace/trace.h: In function 'trace_test_and_set_recursion':
> kernel/trace/trace.h:542:28: error: 'struct task_struct' has no member named 'trace_recursion'
> 
> Adding an explicit dependency avoids the broken configuration.
> 
> Fixes: d59158162e03 ("tracing: Add support for preempt and irq enable/disable events")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> No idea if this is the best solution, it just happened to fix the build
> failure for me.

OK, as same as other tracers, it should select GENERIC_TRACER and TRACER_MAX_TRACE,
and depends on TRACE_IRQFLAGS_SUPPORT, and maybe depends on !ARCH_USES_GETTIMEOFFSET.

Thank you,

> ---
>  kernel/trace/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 1ff10ca078d6..c8c18c793c86 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -164,6 +164,7 @@ config PREEMPTIRQ_EVENTS
>  	bool "Enable trace events for preempt and irq disable/enable"
>  	select TRACE_IRQFLAGS
>  	depends on DEBUG_PREEMPT || !PROVE_LOCKING
> +	depends on TRACING
>  	default n
>  	help
>  	  Enable tracing of disable and enable events for preemption and irqs.
> -- 
> 2.9.0
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>