lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 3 Nov 2017 23:21:44 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Jason Cooper <jason@...edaemon.net>, Andrew Lunn <andrew@...n.ch>,
        Gregory Clement <gregory.clement@...e-electrons.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Ken Ma <make@...vell.com>, Thierry Reding <treding@...dia.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: armada-37xx: remove unused variable

On Fri, Nov 3, 2017 at 10:11 AM, Arnd Bergmann <arnd@...db.de> wrote:
> On Fri, Nov 3, 2017 at 8:46 AM, Linus Walleij <linus.walleij@...aro.org> wrote:
>> On Thu, Nov 2, 2017 at 3:29 PM, Arnd Bergmann <arnd@...db.de> wrote:
>>
>>> A cleanup left behind a temporary variable that is now unused:
>>>
>>> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c: In function 'armada_37xx_irq_startup':
>>> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c:693:20: error: unused variable 'chip' [-Werror=unused-variable]
>>>
>>> This removes the declarations as well.
>>>
>>> Fixes: 3ee9e605caea ("pinctrl: armada-37xx: Stop using struct gpio_chip.irq_base")
>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>>
>> It is used on the head of development, so it's fixed in -next.
>>
>> Is it such a big issue for v4.14 that you think I should send it
>> to Torvalds as a fix at this point or can I just leave it?
>
> I'm confused. The build warning showed up in linux-next yesterday after
> 3ee9e605caea got merged, which removes the user of that variable.
> In v4.14 it is still used.

I just confused myself by trying to apply it to the pin control
tree while the refactorings were in the GPIO tree.

Applied it to the right tree now, thanks!

Linus Walleij

Powered by blists - more mailing lists