linux-kernel - Re: [PATCH] cdrom: always select BLK_SCSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a12f39VV2dwh6BCUn+y9RjDrAQdYAwkbMXKH6KuMb0GcQ@mail.gmail.com>
Date:   Sat, 4 Nov 2017 00:02:19 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Bart Van Assche <Bart.VanAssche@....com>
Cc:     "axboe@...nel.dk" <axboe@...nel.dk>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "hare@...e.de" <hare@...e.de>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "shli@...com" <shli@...com>
Subject: Re: [PATCH] cdrom: always select BLK_SCSI_REQUEST

On Fri, Nov 3, 2017 at 11:55 PM, Bart Van Assche <Bart.VanAssche@....com> wrote:
> On Fri, 2017-11-03 at 23:48 +0100, Arnd Bergmann wrote:
>> When CDROM is enabled, but nothing else selects BLK_SCSI_REQUEST,
>> we get this link error:
>>
>> cdrom.c:(.text+0x7a18): undefined reference to `scsi_cmd_blk_ioctl'
>
> Hello Arnd,
>
> Can you check whether this issue still occurs with Jens' for-4.15/block
> branch (commit a116895fc7b6)?

I haven't tried, but that commit also look like a correct fix for this problem.
We could add my patch as a micro-cleanup on top, but it should not
be required any more now.

I'll drop my patch from the randconfig build and will let you know in
case the problem (or something else) comes back.

        Arnd