lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 3 Nov 2017 16:16:05 -0700
From:   Florian Fainelli <>
To:     Vivien Didelot <>,
        "David S. Miller" <>,
        Andrew Lunn <>
Subject: Re: [PATCH net-next 03/11] net: dsa: simplify tree reference counting

On 11/03/2017 04:05 PM, Vivien Didelot wrote:
> DSA trees have a refcount used to automatically free the dsa_switch_tree
> structure once there is no switch devices inside of it.
> The refcount is incremented when a switch is added to the tree, and
> decremented when it is removed from it.
> But because of kref_init, the refcount is also incremented at
> initialization, and when looking up the tree from the list for symmetry.
> Thus the current code stores the number of switches plus one, and makes
> the switch registration more complex.
> To simplify the switch registration function, we reset the refcount to
> zero after initialization and don't increment it when looking up a tree.
> Signed-off-by: Vivien Didelot <>

Reviewed-by: Florian Fainelli <>

Powered by blists - more mailing lists