linux-kernel - Re: [PATCH] mm: filemap: remove include of hardirq.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171104134709.GA23784@bombadil.infradead.org>
Date:   Sat, 4 Nov 2017 06:47:09 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     Yang Shi <yang.s@...baba-inc.com>
Cc:     mhocko@...nel.org, akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: filemap: remove include of hardirq.h

On Sat, Nov 04, 2017 at 02:47:48AM +0800, Yang Shi wrote:
> in_atomic() has been moved to include/linux/preempt.h, and the filemap.c
> doesn't use in_atomic() directly at all, so it sounds unnecessary to
> include hardirq.h.
> With removing hardirq.h, around 32 bytes can be saved for x86_64 bzImage
> with allnoconfig.

Wait, what?  How would including an unused header file increase the size
of the final image?