linux-kernel - Re: [PATCH] net: sched: cls_u32: use bitwise & rather than logical && on n->flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171104.225201.217339814179113621.davem@davemloft.net>
Date:   Sat, 04 Nov 2017 22:52:01 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: sched: cls_u32: use bitwise & rather than logical
 && on n->flags

From: Colin King <colin.king@...onical.com>
Date: Fri,  3 Nov 2017 08:09:45 +0000

> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently n->flags is being operated on by a logical && operator rather
> than a bitwise & operator. This looks incorrect as these should be bit
> flag operations. Fix this.
> 
> Detected by CoverityScan, CID#1460398 ("Logical vs. bitwise operator")
> 
> Fixes: 245dc5121a9b ("net: sched: cls_u32: call block callbacks for offload")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks Colin.