linux-kernel - Re: [PATCH] block/aoe: discover_timer: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c8772ae6-e0ed-6fc4-340b-455168e978b0@acm.org>
Date:   Fri, 3 Nov 2017 20:39:40 -0400
From:   Ed Cashin <ed.cashin@....org>
To:     Kees Cook <keescook@...omium.org>, Jens Axboe <axboe@...nel.dk>
Cc:     Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block/aoe: discover_timer: Convert timers to use
 timer_setup()

On 11/02/2017 07:31 PM, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly.
> 
> This refactors the discover_timer to remove the needless locking and
> state machine used for synchronizing timer death. Using del_timer_sync()
> will already do the right thing.

Looks OK to me, thanks.

-- 
   Ed