lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20171104220256.GA7012@amd>
Date:   Sat, 4 Nov 2017 23:02:56 +0100
From:   Pavel Machek <pavel@....cz>
To:     Himanshu Jha <himanshujha199640@...il.com>
Cc:     rjw@...ysocki.net, len.brown@...el.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, mcgrof@...nel.org
Subject: Re: [PATCH] freezer: Fix typo in commnent to function
 freezable_schedule_timeout()

On Sun 2017-11-05 03:27:32, Himanshu Jha wrote:
> Signed-off-by: Himanshu Jha <himanshujha199640@...il.com>

ACK.

But note you have typo in the subject ;-).

Plus this kind of bug is usually called thinko.
								Pavel


> diff --git a/include/linux/freezer.h b/include/linux/freezer.h
> index 3995df1..21f5aa0 100644
> --- a/include/linux/freezer.h
> +++ b/include/linux/freezer.h
> @@ -182,7 +182,7 @@ static inline void freezable_schedule_unsafe(void)
>  }
>  
>  /*
> - * Like freezable_schedule_timeout(), but should not block the freezer.  Do not
> + * Like schedule_timeout(), but should not block the freezer.  Do not
>   * call this with locks held.
>   */
>  static inline long freezable_schedule_timeout(long timeout)

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ