linux-kernel - RE: [PATCH] staging: unisys: visorchipset: Use common error handling code in setup_crash_devices_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY4PR07MB3176A9584D22819C938A6ABFF0520@CY4PR07MB3176.namprd07.prod.outlook.com>
Date:   Sat, 4 Nov 2017 01:26:50 +0000
From:   "Kershner, David A" <David.Kershner@...sys.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        *S-Par-Maintainer <SParMaintainer@...sys.com>,
        "Thompson, Bryan E." <bryan.thompson@...sys.com>,
        "Binder, David Anthony" <David.Binder@...sys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sameer Wadgaonkar <sameer.wadgaonkar@...sys.com>,
        "Sell, Timothy C" <Timothy.Sell@...sys.com>
CC:     LKML <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH] staging: unisys: visorchipset: Use common error handling
 code in setup_crash_devices_work_queue()

> -----Original Message-----
> From: SF Markus Elfring [mailto:elfring@...rs.sourceforge.net]
> Sent: Friday, November 3, 2017 3:50 PM
> To: devel@...verdev.osuosl.org; *S-Par-Maintainer
> <SParMaintainer@...sys.com>; Thompson, Bryan E.
> <bryan.thompson@...sys.com>; Binder, David Anthony
> <David.Binder@...sys.com>; Kershner, David A
> <David.Kershner@...sys.com>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>; Sameer Wadgaonkar
> <sameer.wadgaonkar@...sys.com>; Sell, Timothy C
> <Timothy.Sell@...sys.com>
> Cc: LKML <linux-kernel@...r.kernel.org>; kernel-janitors@...r.kernel.org
> Subject: [PATCH] staging: unisys: visorchipset: Use common error handling
> code in setup_crash_devices_work_queue()
>
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 3 Nov 2017 20:37:03 +0100
>
> * Add a jump target so that a specific error message is stored only once
>   at the end of this function implementation.
>
> * Replace four calls of the function "dev_err" by goto statements.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Thanks for the catch!


Acked-by: David Kershner <david.kershner@...sys.com>



> ---
>  drivers/staging/unisys/visorbus/visorchipset.c | 36 
> ++++++++++++------------
> --
>  1 file changed, 16 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
> b/drivers/staging/unisys/visorbus/visorchipset.c
> index fed554a43151..1d54821dd7b6 100644
> --- a/drivers/staging/unisys/visorbus/visorchipset.c
> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> @@ -1231,11 +1231,9 @@ static void
> setup_crash_devices_work_queue(struct work_struct *work)
>  	if (visorchannel_read(chipset_dev->controlvm_channel,
>  			      offsetof(struct visor_controlvm_channel,
>  				       saved_crash_message_count),
> -			      &local_crash_msg_count, sizeof(u16)) < 0) {
> -		dev_err(&chipset_dev->acpi_device->dev,
> -			"failed to read channel\n");
> -		return;
> -	}
> +			      &local_crash_msg_count, sizeof(u16)) < 0)
> +		goto report_read_failure;
> +
>  	if (local_crash_msg_count != CONTROLVM_CRASHMSG_MAX) {
>  		dev_err(&chipset_dev->acpi_device->dev, "invalid
> count\n");
>  		return;
> @@ -1244,30 +1242,24 @@ static void
> setup_crash_devices_work_queue(struct work_struct *work)
>  	if (visorchannel_read(chipset_dev->controlvm_channel,
>  			      offsetof(struct visor_controlvm_channel,
>  				       saved_crash_message_offset),
> -			      &local_crash_msg_offset, sizeof(u32)) < 0) {
> -		dev_err(&chipset_dev->acpi_device->dev,
> -			"failed to read channel\n");
> -		return;
> -	}
> +			      &local_crash_msg_offset, sizeof(u32)) < 0)
> +		goto report_read_failure;
> +
>  	/* read create device message for storage bus offset */
>  	if (visorchannel_read(chipset_dev->controlvm_channel,
>  			      local_crash_msg_offset,
>  			      &local_crash_bus_msg,
> -			      sizeof(struct controlvm_message)) < 0) {
> -		dev_err(&chipset_dev->acpi_device->dev,
> -			"failed to read channel\n");
> -		return;
> -	}
> +			      sizeof(struct controlvm_message)) < 0)
> +		goto report_read_failure;
> +
>  	/* read create device message for storage device */
>  	if (visorchannel_read(chipset_dev->controlvm_channel,
>  			      local_crash_msg_offset +
>  			      sizeof(struct controlvm_message),
>  			      &local_crash_dev_msg,
> -			      sizeof(struct controlvm_message)) < 0) {
> -		dev_err(&chipset_dev->acpi_device->dev,
> -			"failed to read channel\n");
> -		return;
> -	}
> +			      sizeof(struct controlvm_message)) < 0)
> +		goto report_read_failure;
> +
>  	/* reuse IOVM create bus message */
>  	if (!local_crash_bus_msg.cmd.create_bus.channel_addr) {
>  		dev_err(&chipset_dev->acpi_device->dev,
> @@ -1282,6 +1274,10 @@ static void
> setup_crash_devices_work_queue(struct work_struct *work)
>  		return;
>  	}
>  	visorbus_device_create(&local_crash_dev_msg);
> +	return;
> +
> +report_read_failure:
> +	dev_err(&chipset_dev->acpi_device->dev, "failed to read
> channel\n");
>  }
>
>  void visorbus_response(struct visor_device *bus_info, int response,
> --
> 2.15.0


Download attachment "smime.p7s" of type "application/pkcs7-signature" (7862 bytes)