linux-kernel - Re: [PATCH] HID: Wacom: switch Dell canvas into highres mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DE35351F-500C-41C5-90E2-18BC2B48A803@gmail.com>
Date:   Fri, 03 Nov 2017 17:12:08 -0700
From:   Jason Gerecke <killertofu@...il.com>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Jiri Kosina <jikos@...nel.org>,
        Ping Cheng <pinglinux@...il.com>
CC:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: Wacom: switch Dell canvas into highres mode

On November 3, 2017 10:29:47 AM PDT, Benjamin Tissoires <benjamin.tissoires@...hat.com> wrote:
>The Dell Canvas exports 2 collections for the Pen part. The only
>difference between the 2 is that the default one has half the
>resolution
>of the second one.
>
>The Windows driver switches the tablet into the second mode, so we
>should
>behave the same.
>
>Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
>---
>
>Hi,
>
>well, this is not the cleanest way of handling this mode set, but it is
>the
>less intrusive AFAICT.
>
>I was thinking that we might want to add a new field in struct
>wacom_feature,
>but then it wouldn't make sense to keep the set mode specifics in
>_wacom_query_tablet_data().
>
>So I am open to any better suggestion, but this one works and the
>impact on
>other HID generic tablets is null.
>

Hmm. Agreed that this isn't ideal. I'd like to take a look at the descriptor, if you wouldn't mind sharing it. The hardware should be similar to other devices of ours and it might be possible to piggyback on existing code.

Jason

>Cheers,
>Benjamin
>
> drivers/hid/wacom_sys.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
>index 906e654fb0ba..ee71ad9b6cc1 100644
>--- a/drivers/hid/wacom_sys.c
>+++ b/drivers/hid/wacom_sys.c
>@@ -196,6 +196,13 @@ static void wacom_feature_mapping(struct
>hid_device *hdev,
> 		kfree(data);
> 		break;
> 	}
>+
>+	if (hdev->vendor == USB_VENDOR_ID_WACOM &&
>+	    hdev->product == 0x4200 /* Dell Canvas 27 */ &&
>+	    field->application == HID_UP_MSVENDOR) {
>+		wacom->wacom_wac.mode_report = field->report->id;
>+		wacom->wacom_wac.mode_value = 2;
>+	}
> }
> 
> /*


-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.