linux-kernel - Re: [PATCH 00/35] perf annotate: Use generic annotation line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171104102908.GB7511@krava>
Date:   Sat, 4 Nov 2017 11:29:08 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 00/35] perf annotate: Use generic annotation line

On Fri, Nov 03, 2017 at 01:59:01PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Nov 02, 2017 at 01:16:32PM +0100, Jiri Olsa escreveu:
> > On Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa wrote:
> > > hi,
> > > I'm working on script profiling support and came up
> > > with some generic annotation code changes, which IMO
> > > make the code simpler and more generic.
> > > 
> > > The main idea of this patchset is to have generic
> > > struct (annotation_line), which holds the common
> > > profile data. Having this we can easily add new
> > > types, like script annotation support. Currently
> > > there's disasm_line support only.
> > > 
> > > It's also available at:
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git perf/annotate
> > 
> > updated with last perf/core and pushed out
> 
> Can you please ellaborate, write _why_ you're doing these things instead
> of just saying _what_ is being done?

I will.. guess I worked too long and got too familiar with
that, so it did not occur to me there's explanation needed ;-)

> 
> Author: Jiri Olsa <jolsa@...nel.org>
> Date:   Thu Sep 28 23:13:38 2017 +0200
> 
>     perf annotate browser: Change selection to struct annotation_line
>     
>     Use struct annotation_line as a browser::selection.
>     
>     Link: http://lkml.kernel.org/n/tip-hq5alvt759wne4pd1doj2ix7@git.kernel.org
>     Signed-off-by: Jiri Olsa <jolsa@...nel.org>

the idea is to move to generic annotation_line struct in generic places
so it can work over different sources

> 
> commit 902e9181b8f3807a4e51b587c3e5dcd32d61d3b2
> Author: Jiri Olsa <jolsa@...nel.org>
> Date:   Tue Oct 3 15:51:43 2017 +0200
> 
>     perf annotate browser: Rename disasm_line__browser to browser_line
>     
>     Renaming disasm_line__browser function to browser_line.
>     
>     Link: http://lkml.kernel.org/n/tip-xsq9ptt57hc26fytdfnvyoaz@git.kernel.org
>     Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> 
> commit f75c5dcbb250af16621cf0d4d42efa2ba08641cf
> Author: Jiri Olsa <jolsa@...nel.org>
> Date:   Tue Oct 3 15:48:39 2017 +0200
> 
>     perf annotate browser: Rename struct browser_disasm_line to browser_line
>     
>     Renaming struct browser_disasm_line to browser_line.
>     
>     Link: http://lkml.kernel.org/n/tip-tttjkrcxaev97c90x78mpvon@git.kernel.org
>     Signed-off-by: Jiri Olsa <jolsa@...nel.org>

both browser_disasm_line and disasm_line__browser lost the 'disasm'
by using the generic annotation_line struct.. so there's no need
to keep it in its name

I'll update changelogs and resend/repush

thanks,
jirka