linux-kernel - Re: [PATCH] dpaa_eth: avoid uninitialized variable false-positive warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171105.221345.1891928990032403626.davem@davemloft.net>
Date:   Sun, 05 Nov 2017 22:13:45 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     madalin.bucur@....com, jiri@...lanox.com, jhs@...atatu.com,
        camelia.groza@....com, Linyu.Yuan@...atel-sbell.com.cn,
        claudiu.manoil@....com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dpaa_eth: avoid uninitialized variable false-positive
 warning

From: Arnd Bergmann <arnd@...db.de>
Date: Fri,  3 Nov 2017 13:52:24 +0100

> We can now build this driver on ARM, so I ran into a randconfig build
> warning that presumably had existed on powerpc already.
> 
> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c: In function 'sg_fd_to_skb':
> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:1712:18: error: 'skb' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> I'm slightly changing the logic here, to make it obvious to the
> compiler that 'skb' is always initialized.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks.