linux-kernel - Re: [PATCH v10 2/5] serdev: Introduce devm_serdev_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 5 Nov 2017 14:19:48 -0800
From:   Andrey Smirnov <andrew.smirnov@...il.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        linux-serial@...r.kernel.org, Rob Herring <robh@...nel.org>,
        Chris Healy <cphealy@...il.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Lucas Stach <l.stach@...gutronix.de>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Lee Jones <lee.jones@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Pavel Machek <pavel@....cz>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Sebastian Reichel <sebastian.reichel@...labora.co.uk>
Subject: Re: [PATCH v10 2/5] serdev: Introduce devm_serdev_device_open()

On Sun, Nov 5, 2017 at 7:38 AM, Johan Hovold <johan@...nel.org> wrote:
> On Tue, Oct 31, 2017 at 09:36:53AM -0700, Andrey Smirnov wrote:
>> Add code implementing managed version of serdev_device_open() for
>> serdev device drivers that "open" the device during driver's lifecycle
>> only once (e.g. opened in .probe() and closed in .remove()).
>>
>> Cc: linux-kernel@...r.kernel.org
>> Cc: linux-serial@...r.kernel.org
>> Cc: Rob Herring <robh@...nel.org>
>> Cc: cphealy@...il.com
>> Cc: Guenter Roeck <linux@...ck-us.net>
>> Cc: Lucas Stach <l.stach@...gutronix.de>
>> Cc: Nikita Yushchenko <nikita.yoush@...entembedded.com>
>> Cc: Lee Jones <lee.jones@...aro.org>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Cc: Pavel Machek <pavel@....cz>
>> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
>> Cc: Johan Hovold <johan@...nel.org>
>> Cc: Sebastian Reichel <sebastian.reichel@...labora.co.uk>
>> Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>
>> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
>> ---
>>  Documentation/driver-model/devres.txt |  3 +++
>>  drivers/tty/serdev/core.c             | 27 +++++++++++++++++++++++++++
>>  include/linux/serdev.h                |  1 +
>>  3 files changed, 31 insertions(+)
>
>> +int devm_serdev_device_open(struct device *dev, struct serdev_device *serdev)
>> +{
>> +     struct serdev_device **dr;
>> +     int ret;
>> +
>> +     dr = devres_alloc(devm_serdev_device_release, sizeof(*dr), GFP_KERNEL);
>> +     if (!dr)
>> +             return -ENOMEM;
>> +
>> +     ret = serdev_device_open(serdev);
>> +     if (ret) {
>> +             devres_free(dr);
>> +             return ret;
>> +     }
>> +
>> +     *dr = serdev;
>> +     devres_add(dev, dr);
>> +
>> +     return ret;
>
> This would be more readable as return 0.

Sure, I'll change that in v11.

Thanks,
Andrey Smrinov