linux-kernel - Re: [PATCH 2/4] x86, build: Add new paths for isolinux.bin and ldlinux.c32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171105093352.okrgv3623wsjwwin@gmail.com>
Date:   Sun, 5 Nov 2017 10:33:53 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     changbin.du@...el.com
Cc:     hpa@...or.com, tglx@...utronix.de, mingo@...hat.com,
        x86@...nel.org, linux-kernel@...r.kernel.org,
        yamada.masahiro@...ionext.com
Subject: Re: [PATCH 2/4] x86, build: Add new paths for isolinux.bin and
 ldlinux.c32


* changbin.du@...el.com <changbin.du@...el.com> wrote:

> From: Changbin Du <changbin.du@...el.com>
> 
> Recently I failed to build isoimage target, because the path of isolinux.bin
> changed to /usr/xxx/ISOLINUX/isolinux.bin, as well as ldlinux.c32 which
> changed to /usr/xxx/syslinux/modules/bios/ldlinux.c32.
> 
> This patch has a improvement of the file search:
>   - Show a error message instead of silent fail.
>   - Add above new paths.

How about:

  This patch improves the file search logic:
    - Show an error message instead of failing silently
    - Add the new paths listed above.


> +		if [ $i = end -a -z "$isolinux" ] ; then
> +			echo 'Need isolinux.bin, please install syslinux/isolinux'

How about:

			echo 'Need an isolinux.bin file, please install syslinux/isolinux'

Thanks,

	Ingo