linux-kernel - Re: [PATCH 0/4] x86, kbuild: Some improvements for fdimage/isoimage generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171105093752.6e5hj777jbg7rr2b@gmail.com>
Date:   Sun, 5 Nov 2017 10:37:52 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     changbin.du@...el.com
Cc:     hpa@...or.com, tglx@...utronix.de, mingo@...hat.com,
        x86@...nel.org, linux-kernel@...r.kernel.org,
        yamada.masahiro@...ionext.com, Michal Marek <mmarek@...e.com>
Subject: Re: [PATCH 0/4] x86, kbuild: Some improvements for fdimage/isoimage
 generation


* changbin.du@...el.com <changbin.du@...el.com> wrote:

> From: Changbin Du <changbin.du@...el.com>
> 
> This serias is a expansion of below original patch after discussion with Ingo
> and Yamada.
> [PATCH] x86, build: Improve the isolinux searching of isoimage generation
> 
> Changbin Du (4):
>   x86, build: Fact out fdimage/isoimage generation commands to
>     standalone script
>   x86, build: Add new paths for isolinux.bin and ldlinux.c32
>   x86, build: Specify -input-charset=utf-8 for mkisofs
>   x86, boot: Add some generated files to the .gitignore file
> 
>  arch/x86/boot/.gitignore  |   3 ++
>  arch/x86/boot/Makefile    |  59 +++++------------------
>  arch/x86/boot/genimage.sh | 119 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 133 insertions(+), 48 deletions(-)
>  create mode 100644 arch/x86/boot/genimage.sh

Very nice - it looks good to me with the edits I suggested.

Would be nice if the kbuild maintainers could take a look as well - is this how 
boot image construction should be done at the arch level?

Thanks,

	Ingo