linux-kernel - Re: [PATCH 7/7] time: remove timespec64 hack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a27zzk4aJvx3rkQ3E258BeLEYk5jz4dyzT_ozRXY7Ow4g@mail.gmail.com>
Date:   Mon, 6 Nov 2017 22:02:14 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     John Stultz <john.stultz@...aro.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 7/7] time: remove timespec64 hack

On Tue, Oct 24, 2017 at 10:49 PM, John Stultz <john.stultz@...aro.org> wrote:
> On Thu, Oct 19, 2017 at 4:14 AM, Arnd Bergmann <arnd@...db.de> wrote:

>
> This one doesn't seem to build for me...  In the meantime, I'm going
> to go ahead testing with patches 1-6.
>
> jstultz@...ldbox:~/projects/linux/time$ make -j24 bzImage > /dev/null
> fs/select.c: In function ‘compat_core_sys_select’:
> fs/select.c:1244:27: error: passing argument 3 of ‘do_select’ from
> incompatible pointer type [-Werror=incompatible-pointer-types]
>   ret = do_select(n, &fds, end_time);

I looked into this again, as I have some more patches on top now that
I wan to submit soon. The problem you ran into was fixed by Deepa's
"io_getevents: Use timespec64 to represent timeouts" patch that Al
Viro merged into vfs/for-next. It's currently in linux-net but not in
mainline, and I didn't notice the problem because I was building on
linux-next.

If you agree with this patch in principle, I'll resend it after the merge
window, applying this one will help with my "x86: convert x86_platform_ops
to timespec64" that needed a rather ugly workaround otherwise.

      Arnd