linux-kernel - Re: iSCSI-target: Use common error handling code in iscsi_decode_text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49e62625-8c1d-5bbe-2ddd-e25e117754db@users.sourceforge.net>
Date:   Mon, 6 Nov 2017 22:11:06 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Alan Cox <gnomes@...rguk.ukuu.org.uk>, linux-scsi@...r.kernel.org,
        target-devel@...r.kernel.org
Cc:     Arun Easi <arun.easi@...ium.com>,
        Bart Van Assche <bart.vanassche@...disk.com>,
        "Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: iSCSI-target: Use common error handling code in
 iscsi_decode_text_input()

>> Add a jump target so that a bit of exception handling can be better reused
>> at the end of this function.
> 
> Why not look at what the C compiler generates before making the code
> less readable ?

* Does the adjusted source code layout fit to information from the section
  “7) Centralized exiting of functions” in the document “coding-style.rst”?

* Would you find a reduction of 16 bytes for the object code useful for
  the affected function implementation?

Regards,
Markus