linux-kernel - Re: [PATCH] selftests: fix compile error for sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a23bae8-00ee-eeb6-0b51-16132aab5b1a@osg.samsung.com>
Date:   Mon, 6 Nov 2017 16:35:21 -0700
From:   Shuah Khan <shuahkh@....samsung.com>
To:     Lei Yang <Lei.Yang@...driver.com>
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <shuahkh@....samsung.com>,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] selftests: fix compile error for sync

On 11/05/2017 03:08 AM, Lei Yang wrote:
> I got below error message when building sync test:
> 
> make[1]: Entering directory `tools/testing/selftests/sync'
> gcc -c sync.c -o tools/testing/selftests/sync/sync.o
> sync.c:42:29: fatal error: linux/sync_file.h: No such file or directory
>  #include <linux/sync_file.h>
> 
> obviously, CFLAGS and LDFLAGS are not used when comipling.
> 
> Signed-off-by: Lei Yang <Lei.Yang@...driver.com>
> ---
>  tools/testing/selftests/sync/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/sync/Makefile b/tools/testing/selftests/sync/Makefile
> index 8e04d0a..46cbcc3 100644
> --- a/tools/testing/selftests/sync/Makefile
> +++ b/tools/testing/selftests/sync/Makefile
> @@ -29,9 +29,9 @@ $(TEST_CUSTOM_PROGS): $(TESTS) $(OBJS)
>  	$(CC) -o $(TEST_CUSTOM_PROGS) $(OBJS) $(TESTS) $(CFLAGS) $(LDFLAGS)
>  
>  $(OBJS): $(OUTPUT)/%.o: %.c
> -	$(CC) -c $^ -o $@
> +	$(CC) -c $^ -o $@ $(CFLAGS) $(LDFLAGS)
>  
>  $(TESTS): $(OUTPUT)/%.o: %.c
> -	$(CC) -c $^ -o $@
> +	$(CC) -c $^ -o $@ $(CFLAGS) $(LDFLAGS)
>  
>  EXTRA_CLEAN := $(TEST_CUSTOM_PROGS) $(OBJS) $(TESTS)
> 

How are you building the test? I am not seeing the error on linux-4.14.0-rc8

thanks,
-- Shuah