linux-kernel - Re: [PATCH] usb:xhci fix panic in xhci_free_virt_devices_depth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1bb9152e-083c-a2ac-4b71-94b14454c012@huawei.com>
Date:   Mon, 6 Nov 2017 16:07:55 +0800
From:   Chen Yu <chenyu56@...wei.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     <wangbinghui@...ilicon.com>, <mathias.nyman@...el.com>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <fanning4@...ilicon.com>, <lirui39@...ilicon.com>,
        <yangdi10@...ilicon.com>, <groeck@...gle.com>,
        <john.stultz@...aro.org>
Subject: Re: [PATCH] usb:xhci fix panic in xhci_free_virt_devices_depth_first



On 2017/11/6 15:59, Greg KH wrote:
>>
>> diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
>> index 2a82c927ded2..295789d993b0 100644
>> --- a/drivers/usb/host/xhci-mem.c
>> +++ b/drivers/usb/host/xhci-mem.c
>> @@ -947,6 +947,11 @@ void xhci_free_virt_devices_depth_first(struct xhci_hcd *xhci, int slot_id)
>>  	if (!vdev)
>>  		return;
>>  
>> +	if (WARN_ON(!vdev->real_port)) {
>> +		xhci_warn(xhci, "Bad vdev->real_port\n");
> 
> Why warn twice?  What will that help?
> 
> thanks,
> 
> greg k-h
> 
> .
> 

I will fix that and send patch V2. Thanks!

Best regards
Yu Chen