linux-kernel - Re: [PATCH] nfc: s3fwrn5: make array match static const, reduces object code size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171106000343.GC27831@zurbaran.ger.intel.com>
Date:   Mon, 6 Nov 2017 01:03:43 +0100
From:   Samuel Ortiz <sameo@...ux.intel.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Robert Baldyga <r.baldyga@...sung.com>,
        Krzysztof Opasiak <k.opasiak@...sung.com>,
        linux-nfc@...ts.01.org, linux-wireless@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfc: s3fwrn5: make array match static const, reduces
 object code size

Hi Colin,

On Tue, Sep 19, 2017 at 03:25:15PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate the read-only array match on the stack, instead make
> it static const.  Makes the object code smaller by over 310 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>    8304	   1084	    128	   9516	   252c	drivers/nfc/s3fwrn5/firmware.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>    7894	   1180	    128	   9202	   23f2	drivers/nfc/s3fwrn5/firmware.o
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/nfc/s3fwrn5/firmware.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
Applied to nfc-next, thanks.

Cheers,
Samuel.