linux-kernel - RE: [PATCH] phy: rcar-gen3-usb2: select USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Nov 2017 09:32:36 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Kishon Vijay Abraham I <kishon@...com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] phy: rcar-gen3-usb2: select USB_COMMON

Hi Arnd,

> From: Arnd Bergmann, Sent: Thursday, November 2, 2017 8:57 PM
> 
> When USB is disabled, we get a link error for this driver
> because of the added OTG support
> 
> drivers/phy/renesas/phy-rcar-gen3-usb2.o: In function `rcar_gen3_phy_usb2_probe':
> phy-rcar-gen3-usb2.c:(.text+0x250): undefined reference to `of_usb_get_dr_mode_by_phy'
> 
> Other phy drivers select USB_COMMON for this, so let's do the same
> here.
> 
> Fixes: 7e0540f41332 ("phy: rcar-gen3-usb2: check dr_mode for otg mode")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thank you for the patch!

Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>

Best regards,
Yoshihiro Shimoda